Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show errors from launching and fetching Metals #513

Merged
merged 1 commit into from
Mar 4, 2021

Conversation

tgodzik
Copy link
Contributor

@tgodzik tgodzik commented Mar 2, 2021

Not sure if it's the right way to do it in typescript, but it would be good to have more information when something fails. Currently, we can only guess what happened. This should allow the user to at least paste us the error message.

I recommend using Hide whitespace changes option.

@tgodzik tgodzik requested review from ckipp01 and gabro March 2, 2021 17:54
Copy link
Member

@gabro gabro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple of suggestions

src/extension.ts Outdated Show resolved Hide resolved
src/extension.ts Outdated Show resolved Hide resolved
@tgodzik tgodzik merged commit 312c161 into scalameta:master Mar 4, 2021
@tgodzik tgodzik deleted the better-errors branch March 4, 2021 10:14
kasiaMarek pushed a commit to kasiaMarek/metals-vscode that referenced this pull request Mar 29, 2023
…rn/types/node-18.11.4

chore(deps-dev): bump @types/node from 18.11.3 to 18.11.4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants