Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: switch from extensionDependencies to extensionPack [skip pre] #835

Merged
merged 1 commit into from
Jan 20, 2022

Conversation

kpodsiad
Copy link
Member

It is a very subtle change. However, it's plays a huge role in extension tests where, for some reason, scala-lang.scala extension can't be found if it's specified in extensionDependencies. Because Metals doesn't depend on Scala Syntax API it's safe to make this change.

Screenshot 2022-01-20 at 13 06 34

Copy link
Member

@gabro gabro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 makes sense

@gabro gabro merged commit bace07c into scalameta:main Jan 20, 2022
@kpodsiad kpodsiad deleted the extension-dependencies branch January 21, 2022 07:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants