-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci, tests: add extension tests #830
Conversation
126f8f4
to
719bb4a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, though I would move the extension pack change to a different PR otherwise it's kind of hidden insid ehere.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice! It looks good, just one non-blocking question
719bb4a
to
ef41098
Compare
* add extension tests which allow to use vscode API https://code.visualstudio.com/api/working-with-extensions/continuous-integration#github-actions
ef41098
to
8a561ef
Compare
I changed jest configuration, running |
add extension tests which allow to use vscode API https://code.visualstudio.com/api/working-with-extensions/continuous-integration#github-actions.
I want to use
vscode
API to test Test Explorer behavior - creating test items viaTestController
and etc.split
test
dir intounit
andextension
- although I thinkextension
could be placed elsewherechangeextensionDependencies
toextensionPack
inpackage.json
. Metals do not depend on Scala syntax, but these extensions should be bundled - see https://code.visualstudio.com/api/references/extension-manifest#extension-packsActually, it was done in chore: switch from
extensionDependencies
toextensionPack
[skip pre] #835. There's also a explanation why.