Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci, tests: add extension tests #830

Merged
merged 1 commit into from
Jan 20, 2022
Merged

Conversation

kpodsiad
Copy link
Member

@kpodsiad kpodsiad commented Jan 18, 2022

@kpodsiad kpodsiad force-pushed the extension-tests branch 3 times, most recently from 126f8f4 to 719bb4a Compare January 19, 2022 12:04
@kpodsiad kpodsiad marked this pull request as ready for review January 19, 2022 12:09
package.json Outdated Show resolved Hide resolved
@kpodsiad kpodsiad changed the title tests: add extension tests ci, tests: add extension tests Jan 19, 2022
Copy link
Contributor

@tgodzik tgodzik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, though I would move the extension pack change to a different PR otherwise it's kind of hidden insid ehere.

package.json Outdated Show resolved Hide resolved
Copy link
Member

@gabro gabro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice! It looks good, just one non-blocking question

package.json Outdated Show resolved Hide resolved
@kpodsiad
Copy link
Member Author

I changed jest configuration, running yarn test will only run unit tests

@kpodsiad kpodsiad requested a review from tgodzik January 20, 2022 14:21
@kpodsiad kpodsiad merged commit e6f74ce into scalameta:main Jan 20, 2022
@kpodsiad kpodsiad deleted the extension-tests branch January 20, 2022 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants