Change displayBuildTarget to listBuildTargets

[Arthurm1]

see scalameta/metals#3649

This shifts the burden of quickpicking from Metals onto the client

[Arthurm1]

Needs scalameta/metals-languageclient#419 to pass checks

[tgodzik]

Looks good! Just one small suggestion in regards to parsing, but it can be ignored.

Otherwise, let's bump the language client and default metals server version once the PR in metals is merged (which I will do in a sec.)

[tgodzik]

Could we instead parse it as an URI and get the query parameters?

[Arthurm1]

It would still only get us halfway there.

A URI example from the treeview would be...
projects:file:/root/metals/.mtags/?id=mtags3!/_root_/

Using URLSearchParams(uri).get("id") would give...
mtags3!/_root_/

So I'd still need to parse for ! to get mtags3

I can do that if you want?

[tgodzik]

We could then just do split("!") so maybe it's a bit clrearer than a regex?

[kpodsiad]

This splitting part seems too much for me.
IMO in this case regex is simpler and with the proper example in the comment (exists) isn't also that hard to understand.

[Arthurm1]

I'm easy. Ideally the treeviewuri would be in the format we already want but it's used to work out how to drill down into classes/methods so I wasn't going to change it. I tried to extract the target name with URLSearchParams but it doesn't like our URI so converts the whole thing to a single query param which is no help. I guess URI != URL

[tgodzik]

ok then, for me whichever is fine

[Arthurm1]

I've changed to split + split. Does the job. 🤷

[kpodsiad]

Suggested change

	client
	.sendRequest(ExecuteCommandRequest.type, {
	command: ServerCommands.ListBuildTargets,
	})
	.then(async (...args: any[]) => {
	const targets = args?.[0] as string[];
	window.showQuickPick(targets).then((target) => {
	if (target) {
	displayBuildTarget(target);
	}
	});
	});
	const targets = await client.sendRequest(ExecuteCommandRequest.type, {
	command: ServerCommands.ListBuildTargets,
	});
	const picked = await window.showQuickPick(targets);
	if (picked) {
	displayBuildTarget(picked);
	}

Should work the same and, at least for me, it's more readable

[Arthurm1]

I've made the change. Works for me. I don't know typescript well enough to know the implications.

[tgodzik]

LGTM!