-
Notifications
You must be signed in to change notification settings - Fork 326
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mechanism to log json requests and responses, to and from client #321
Comments
I believe logs are already there, simply disabled since they have status trace. |
I think after we complete #318 it will be easier to programmatically set the log level based on a system property like |
@gabro is there a way to enable them? |
You can update the logback xml configuration
…On Thu, 28 Jun 2018 at 20:50, Yash Yadavalli ***@***.***> wrote:
@gabro <https://github.com/gabro> is there a way to enable them?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#321 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ABV8XULFdYyMwLhZ3IwUd2W-hyvAjAHxks5uBSVdgaJpZM4U70LP>
.
|
Fixed in #337. All incoming and outgoing JSON requests can now be seen by following instructions that are printed during startup of the server
If the trace file exists, then you can {
"jsonrpc": "2.0",
"method": "build/taskFinish",
"params": {
"taskId": {
"id": "1"
},
"eventTime": 1543340644550,
"message": "Compiled \u0027test-workspace\u0027",
"dataKind": "compile-report",
"data": {
"target": {
"uri": "file:/Users/olafurpg/dev/metals/test-workspace/?id\u003dtest-workspace"
},
"errors": 0,
"warnings": 0
}
}
}
{
"jsonrpc": "2.0",
"id": "6",
"result": {
"statusCode": 1
}
} This works for both LSP and BSP communication. |
We should provide a way to log the json at the boundary to make sure different clients are working correctly. It also helps debug a lot of client related issues.
The text was updated successfully, but these errors were encountered: