Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

No documentation shown when using value forwarders #5885

Closed
tgodzik opened this issue Nov 28, 2023 · 0 comments · Fixed by #5912
Closed

No documentation shown when using value forwarders #5885

tgodzik opened this issue Nov 28, 2023 · 0 comments · Fixed by #5912
Assignees
@jkciesluk
Labels
bug Something that is making a piece of functionality unusable Scala 3 Generic ticket relating to Scala 3
Projects
Metals Issue Board
Milestone
Metals v1.2.1

Comments

@tgodzik
Copy link
Contributor

tgodzik commented Nov 28, 2023 •
edited
Loading

Describe the bug

When using value forwarders such as in case of List:

val List = scala.collection.immutable.List

We will not get the actual documentation in completions (probably other places such as hover also) for the List object.

This was caused by the recent changes to newest Scala 3 nightlies.

Expected behavior

Documentation for list should be shown. Most likely we need to fix it in the compiler itself.

This also influences some completions and this was marked near the affected test cases.

Operating system

Linux

Editor/Extension

VS Code

Version of Metals

v1.1.0

Extra context or search terms

documentation value forwarders list
@tgodzik tgodzik added bug Something that is making a piece of functionality unusable Scala 3 Generic ticket relating to Scala 3 labels Nov 28, 2023
@tgodzik tgodzik added this to Triage in Metals Issue Board via automation Nov 28, 2023
@jkciesluk jkciesluk self-assigned this Dec 5, 2023
This was referenced Dec 5, 2023
Merged
Merged
tgodzik added a commit to scala/scala3 that referenced this issue Dec 6, 2023
@tgodzik
Show documentation for value forwarders in completions (#19200)
96e2720 
This was changed in #18874

connected to scalameta/metals#5885
Metals Issue Board automation moved this from Triage to Done Dec 8, 2023
@kasiaMarek kasiaMarek added this to the Metals v1.2.1 milestone Feb 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jkciesluk jkciesluk

Labels
bug Something that is making a piece of functionality unusable Scala 3 Generic ticket relating to Scala 3
Projects
Metals Issue Board
Archived in project
Metals Issue Board
Done
Milestone
Metals v1.2.1
Development

Successfully merging a pull request may close this issue.

chore: adjust completions tests for value forwarders jkciesluk/metals
3 participants
@tgodzik @kasiaMarek @jkciesluk