Skip to content

Show documentation for value forwarders in completions #19200

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 6, 2023
Merged

Show documentation for value forwarders in completions #19200

merged 1 commit into from
Dec 6, 2023
+9 −5

Conversation

jkciesluk
Copy link
Contributor

This was changed in #18874

connected to scalameta/metals#5885

@jkciesluk jkciesluk mentioned this pull request Dec 5, 2023
Merged
@jkciesluk jkciesluk requested review from tgodzik and rochala December 5, 2023 14:22
tgodzik
tgodzik approved these changes Dec 6, 2023
View reviewed changes
Copy link
Contributor

@tgodzik tgodzik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@tgodzik tgodzik merged commit 96e2720 into scala:main Dec 6, 2023
@tgodzik tgodzik added backport:nominated If we agree to backport this PR, replace this tag with "backport:accepted", otherwise delete it. area:presentation-compiler Related to the presentation compiler module used by Metals and possibly other tools labels Dec 6, 2023
@jkciesluk jkciesluk deleted the completion-doc-forwarders branch December 6, 2023 13:35
@Kordyjan Kordyjan added this to the 3.4.0 milestone Dec 20, 2023
@WojciechMazur WojciechMazur mentioned this pull request Jun 25, 2024
Merged
WojciechMazur added a commit that referenced this pull request Jun 26, 2024
@WojciechMazur
Backport "Show documentation for value forwarders in completions" to …
8b20064 
…LTS (#20788)

Backports #19200 to the LTS branch.

PR submitted by the release tooling.
[skip ci]
@WojciechMazur WojciechMazur removed the backport:nominated If we agree to backport this PR, replace this tag with "backport:accepted", otherwise delete it. label Nov 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tgodzik tgodzik tgodzik approved these changes

@rochala rochala Awaiting requested review from rochala

Assignees
No one assigned
Labels
area:presentation-compiler Related to the presentation compiler module used by Metals and possibly other tools
Projects
None yet
Milestone
3.4.0
Development

Successfully merging this pull request may close these issues.
4 participants
@jkciesluk @tgodzik @Kordyjan @WojciechMazur