Keep modifiers when implementing abstract members #1762
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tgodzik
requested changes
May 18, 2020
| @@ -213,6 +213,16 @@ trait OverrideCompletions { this: MetalsGlobal => | |||
| if (sym.isLazy) "lazy " | |||
| else "" | |||
|
|
|||
| val _modifs = sym.flagString | |||
| .replace("package ", "") | |||
There was a problem hiding this comment.
Do we need to do this? We are not doing overrides for any of those symbol types.
There was a problem hiding this comment.
Not sure if this is a bug or intended behaviour but flagString generates modifiers like protected[package x.y.z] and they need to be stripped manually.
There was a problem hiding this comment.
What about object, trait or class ?
There was a problem hiding this comment.
I meant, does those keywords can appear here even? You mentioned protected[package x.y.z] , but why would trait appear here?
There was a problem hiding this comment.
scala> trait A {
| trait AB {
| private[A] val x = 3
| }
| }
trait A
There was a problem hiding this comment.
We could do:
val _modifs =
sym.flagString.replace(
sym.privateWithin.toString(),
sym.privateWithin.name.toString()
)
mtags/src/main/scala-2/scala/meta/internal/pc/completions/OverrideCompletions.scala
Show resolved
Hide resolved
ckipp01
added
bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1759
Not sure if this is a bug or intended behaviour but
flagStringgenerates modifiers likeprotected[package x.y.z]and they need to be stripped manually.