Fix go to defintion for Sbt's Scala sources #1984
Conversation
| pos => { | ||
| new LspPosition(pos.getLine() - 1, pos.getCharacter() - ident.size) | ||
| }, | ||
| filterOutLocations = { loc => loc.getUri().isWorksheet } |
There was a problem hiding this comment.
we shouldn't adjust positions outside of the worksheets.
There was a problem hiding this comment.
🤔 not work for now, but I'm wondering for clarity in the future if we should try to unify where we have adjustments done. For example we check here for worksheets and sbt and adjust accordingly. However, Ammonite also has some adjustments that we do, but those live in Ammonite.scala. I can see how that could be confusing from someone on the outside. Or, is it a good distinction to have that adjustments related to the PC are in AdjustLspData and other things live in their corresponding places? What do you think?
There was a problem hiding this comment.
Yeah, I will move the adjustments to separate locations
| @@ -77,6 +72,24 @@ trait AdjustLspData { | |||
| } | |||
| } | |||
|
|
|||
| case class AdjustLspPos( | |||
There was a problem hiding this comment.
I normally don't love case classes that are verbs. What do you think of AdjustedLspPos?
| pos => { | ||
| new LspPosition(pos.getLine() - 1, pos.getCharacter() - ident.size) | ||
| }, | ||
| filterOutLocations = { loc => loc.getUri().isWorksheet } |
There was a problem hiding this comment.
🤔 not work for now, but I'm wondering for clarity in the future if we should try to unify where we have adjustments done. For example we check here for worksheets and sbt and adjust accordingly. However, Ammonite also has some adjustments that we do, but those live in Ammonite.scala. I can see how that could be confusing from someone on the outside. Or, is it a good distinction to have that adjustments related to the PC are in AdjustLspData and other things live in their corresponding places? What do you think?
tgodzik
force-pushed
the
fix-goto-sbt
branch
3 times, most recently
from
40c6860
to
7fec10e
Compare
Fixes #1981