Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add release notes for 0.9.3 #2008

Merged
merged 1 commit into from
Aug 19, 2020
Merged

Add release notes for 0.9.3 #2008

merged 1 commit into from
Aug 19, 2020

Conversation

tgodzik
Copy link
Contributor

@tgodzik tgodzik commented Aug 19, 2020

No description provided.

@@ -196,8 +196,6 @@ guide them. In the end users should end up with something like this:
"name": "Test class",
// full name of the class to run
"testClass": "com.example.Test",
// optional jvm properties to use
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was actually not true, there is nothing we can customize about test yet.

Copy link
Contributor

@kpbochenek kpbochenek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

awesome to see worksheets for scala3 in 👍

Copy link
Member

@ckipp01 ckipp01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few nits!

website/blog/2020-08-19-lithium.md Outdated Show resolved Hide resolved
website/blog/2020-08-19-lithium.md Outdated Show resolved Hide resolved
website/blog/2020-08-19-lithium.md Outdated Show resolved Hide resolved
website/blog/2020-08-19-lithium.md Outdated Show resolved Hide resolved
website/blog/2020-08-19-lithium.md Outdated Show resolved Hide resolved
website/blog/2020-08-19-lithium.md Outdated Show resolved Hide resolved
website/blog/2020-08-19-lithium.md Outdated Show resolved Hide resolved
website/blog/2020-08-19-lithium.md Outdated Show resolved Hide resolved
website/blog/2020-08-19-lithium.md Outdated Show resolved Hide resolved
website/blog/2020-08-19-lithium.md Outdated Show resolved Hide resolved
@tgodzik
Copy link
Contributor Author

tgodzik commented Aug 19, 2020

Just a few nits!

Thanks, fixed them all now!

@tgodzik tgodzik requested a review from ckipp01 August 19, 2020 16:23
Copy link
Member

@ckipp01 ckipp01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! LGTM! 🚀


```
cs install ammonite
amm bin/release_notes.sc
amm ./bin/merged_prs.sc <tag1> <tag2> "<github_api_token>"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I simplified the usage a bit.

@tgodzik tgodzik merged commit aca6035 into scalameta:main Aug 19, 2020
@tgodzik tgodzik deleted the release-notes branch August 19, 2020 18:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants