Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use 127.0.0.1 address always for DebugProvider #2135

Merged
merged 1 commit into from
Oct 14, 2020
Merged

Use 127.0.0.1 address always for DebugProvider #2135

merged 1 commit into from
Oct 14, 2020

Conversation

tgodzik
Copy link
Contributor

@tgodzik tgodzik commented Oct 13, 2020

Fixes #2128

@tgodzik tgodzik requested a review from ckipp01 October 13, 2020 17:11
ckipp01
ckipp01 approved these changes Oct 13, 2020
View reviewed changes
Copy link
Member

@ckipp01 ckipp01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍 and the test failure seems unrelated. LGTM!

@tgodzik tgodzik merged commit 7af1405 into scalameta:main Oct 14, 2020
@tgodzik tgodzik deleted the fix-dns branch October 14, 2020 09:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ckipp01 ckipp01 ckipp01 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Running / Debugging doesnt work when connected to a VPN
2 participants
@tgodzik @ckipp01