Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow for reset in html doctor #2172

Merged
merged 1 commit into from
Nov 1, 2020
Merged

Allow for reset in html doctor #2172

merged 1 commit into from
Nov 1, 2020

Conversation

ckipp01
Copy link
Member

@ckipp01 ckipp01 commented Oct 31, 2020

This pr adds in an (Reset) option in the html view of the doctor to reset your build server choice. The button is only shown if you've explicitly chosen a build server. So for a user that just connects and uses the default, they will see that they are using Bloop as their build server, but won't be able to reset it, because there is no choice made.

So after making a choice if they do a bsp-switch, they the flow would look like this if they wanted to use Doctor to switch back and forth.

2020-10-31 13 51 43

Closes #2171

@ckipp01 ckipp01 added improvement Not a bug or a feature, but something general we can improve sbt server Relates to sbt BSP server support labels Nov 1, 2020
Copy link
Contributor

@tgodzik tgodzik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@gabro
Copy link
Member

gabro commented Nov 1, 2020

How does this work in tools that don't use html, such as vim? There's another dedicated command and this is just a shortcut?

@ckipp01
Copy link
Member Author

ckipp01 commented Nov 1, 2020

How does this work in tools that don't use html, such as vim? There's another dedicated command and this is just a shortcut?

Yup, exactly. So what the html view is doing is just adding the param to reset-choice to be sent in. If there is no param, then you enter the "interactive" reset. So in Vim it would look like this:

2020-11-01 13 44 04

This worked before, and it also works in VS Code if you just trigger it from the command palette.

@ckipp01 ckipp01 merged commit 4807f08 into scalameta:main Nov 1, 2020
@ckipp01 ckipp01 deleted the doctorFix branch November 1, 2020 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Not a bug or a feature, but something general we can improve sbt server Relates to sbt BSP server support
Projects
None yet
Development

Successfully merging this pull request may close these issues.

No build server reset button in html view of doctor
3 participants