Automatically backtick symbols when renaming #2605
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ckipp01
reviewed
Mar 15, 2021
metals/src/main/scala/scala/meta/internal/rename/RenameProvider.scala
Outdated
Show resolved
Hide resolved
tgodzik
force-pushed
the
auto-backtick
branch
2 times, most recently
from
642f2d2
to
70c8f9c
Compare
tgodzik
commented
Mar 15, 2021
| @@ -288,7 +288,7 @@ class RenameLspSuite extends BaseRenameLspSuite("rename") { | |||
| | "" <<::>> user | |||
| |} | |||
| |""".stripMargin, | |||
| newName = "method:" | |||
| newName = "+++:" | |||
There was a problem hiding this comment.
That was actually a wrongly named method - method: should be wrapped in backticks, which it started doing.
tgodzik
commented
Mar 15, 2021
tgodzik
force-pushed
the
auto-backtick
branch
2 times, most recently
from
c069b84
to
a717a39
Compare
tgodzik
commented
Mar 15, 2021
| @@ -241,7 +231,7 @@ final class RenameProvider( | |||
| realName = rng.inString(semanticDb.text) | |||
| if occ.symbol == occurence.symbol && | |||
| withoutBacktick(realName) == withoutBacktick(renameName) | |||
| } yield realLocationWithoutBackticks(realName, rng.toLSP) | |||
| } yield new Location(uri, rng.toLSP) | |||
There was a problem hiding this comment.
If new name is checked to have backticks then this is not needed.
In cases where a symbol name is not valid we should automatically wrap it in backticks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In cases where a symbol name is not valid we should automatically wrap it in backticks