Run Scala 3 migrate on mtags sources #2617
Conversation
While testing out https://github.com/scalacenter/scala3-migrate I decided to run it on mtags module to see if there is anything that we can improve. This included: - changes to scalac options for Scala 3 - scalafix rewrites that deals with 2.13 deprecations, which weren't sctrictly neccessary, but might be usful for the future if we decide to move some of the Scala 2 code - I also added a test case for one of Scala 3 issues we had (hovers on extension methods)
| @@ -71,6 +71,21 @@ class HoverScala3TypeSuite extends BaseHoverSuite { | |||
| |""".stripMargin.hover | |||
| ) | |||
|
|
|||
| // https://github.com/scalameta/metals/issues/1991 | |||
| check( | |||
| "extension-methods", | |||
There was a problem hiding this comment.
Might be fixed in 3.0.0-RC2, so I wanted to add the test case to close the issue when updating.
| @@ -62,7 +62,7 @@ object Identifier { | |||
| def backtickWrap(s: String): String = { | |||
| if (s.isEmpty) "``" | |||
| else if (s(0) == '`' && s.last == '`') s | |||
| else if (needsBacktick(s)) '`' + s + '`' | |||
| else if (needsBacktick(s)) "" + ('`') + s + '`' | |||
There was a problem hiding this comment.
I've seen this in a couple places where it prefaces with an empty string. What's the reasoning for that?
There was a problem hiding this comment.
I was also confused, but it seems the reason is https://scalacenter.github.io/scala-3-migration-guide/docs/incompatibilities/dropped-features.html#any2stringadd-conversion
There was a problem hiding this comment.
huh, alright, thanks for linking that. I hope this doesn't become confusing for someone in the future that comes across this and wonders why there is a "" prefacing it. I can see myself seeing that just removing it 😆
There was a problem hiding this comment.
Hm. I've just realized that this line might look less weird if at least the first backtick was a type of String:
else if (needsBacktick(s)) "`"+ s + "`"`There was a problem hiding this comment.
ach yes, I didn't notice the comments when merging, sorry!
While testing out https://github.com/scalacenter/scala3-migrate I decided to run it on mtags module to see if there is anything that we can improve.
This included: