Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add try in order not to break debugging session #3265

Merged
merged 1 commit into from
Nov 3, 2021

Conversation

tgodzik
Copy link
Contributor

@tgodzik tgodzik commented Nov 3, 2021

While testing on windows I encounter still some issues for classes within src.zip JDK sources.

It was throwing FileSytemNotFound exceptions and I was not able to figure out what was going on.

This is a quickfix for this release so that it's possible to use breakpoints properly on Windows, the only thing this will do is that it might sometimes be impossible to go to JDK sources.

While testing on windows I encounter still some issues for classes within `src.zip` JDK sources.

It was throwing FileSytemNotFound exceptions and I was not able to figure out what was going on.

This is a quickfix for this release so that it's possible to use breakpoints properly on Windows, the only thing this will do is that it might sometimes be impossible to go to JDK sources.
@tgodzik tgodzik requested a review from adpi2 November 3, 2021 12:09
@tgodzik
Copy link
Contributor Author

tgodzik commented Nov 3, 2021

Raised the issue here: #3266

I need to properly look into all the issues around this, but that might wait.

@tgodzik tgodzik merged commit 15e98f4 into scalameta:main Nov 3, 2021
@tgodzik tgodzik deleted the add-try branch November 3, 2021 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants