fix: do not call doctor.check() on each build target compilation end
#3768
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
March 28, 2022 12:23
kpodsiad
commented
Mar 29, 2022
metals/src/main/scala/scala/meta/internal/metals/MetalsLanguageServer.scala
Show resolved
Hide resolved
metals/src/main/scala/scala/meta/internal/metals/doctor/Doctor.scala
Outdated
Show resolved
Hide resolved
metals/src/main/scala/scala/meta/internal/metals/MetalsLanguageServer.scala
Outdated
Show resolved
Hide resolved
kpodsiad
commented
Mar 29, 2022
kpodsiad
force-pushed
the
chore/doctor-fix
branch
from
b9173c0
to
2dfe3fd
Compare
ckipp01
reviewed
Mar 29, 2022
metals/src/main/scala/scala/meta/internal/metals/InitializationOptions.scala
Show resolved
Hide resolved
ckipp01
reviewed
Mar 29, 2022
kpodsiad
commented
Mar 29, 2022
Comment on lines
+102
to
+137
| ```typescript | ||
| interface InitializationOptions: { | ||
| compilerOptions: { | ||
| completionCommand?: string; | ||
| isCompletionItemDetailEnabled?: boolean; | ||
| isCompletionItemDocumentationEnabled?: boolean; | ||
| isCompletionItemResolve?: boolean; | ||
| isHoverDocumentationEnabled?: boolean; | ||
| isSignatureHelpDocumentationEnabled?: boolean; | ||
| overrideDefFormat?: "ascii" | "unicode"; | ||
| parameterHintsCommand?: string; | ||
| snippetAutoIndent?: boolean; | ||
| } | ||
| "copyWorksheetOutputProvider": boolean, | ||
| "debuggingProvider": boolean, | ||
| "decorationProvider": boolean, | ||
| "didFocusProvider": boolean, | ||
| "disableColorOutput" boolean, | ||
| "doctorProvider": "json" | "html", | ||
| "executeClientCommandProvider": boolean, | ||
| "globSyntax": "vscode" | "uri" | ||
| "icons": "octicons" | "vscode" | "unicode", | ||
| "inlineDecorationProvider": boolean, | ||
| "inputBoxProvider": boolean, | ||
| "isExitOnShutdown" : boolean, | ||
| "isHttpEnabled": boolean, | ||
| "commandInHtmlFormat": "vscode" | "sublime", | ||
| "openFilesOnRenameProvider": boolean, | ||
| "openNewWindowProvider": boolean, | ||
| "quickPickProvider": boolean, | ||
| "renameFileThreshold": number, | ||
| "slowTaskProvider": boolean, | ||
| "statusBarProvider": "on" | "off" | "show-message" | "log-message", | ||
| "treeViewProvider": boolean | ||
| debuggingProvider?: boolean; | ||
| decorationProvider?: boolean; | ||
| inlineDecorationProvider?: boolean; | ||
| didFocusProvider?: boolean; | ||
| doctorProvider?: "json" | "html"; | ||
| executeClientCommandProvider?: boolean; | ||
| globSyntax?: "vscode" | "uri"; | ||
| icons?: "vscode" | "octicons" | "atom" | "unicode"; | ||
| inputBoxProvider?: boolean; | ||
| isVirtualDocumentSupported?: boolean; | ||
| isExitOnShutdown?: boolean; | ||
| isHttpEnabled?: boolean; | ||
| openFilesOnRenameProvider?: boolean; | ||
| quickPickProvider?: boolean; | ||
| renameFileThreshold?: number; | ||
| slowTaskProvider?: boolean; | ||
| statusBarProvider?: "on" | "off" | "log-message" | "show-message"; | ||
| treeViewProvider?: boolean; | ||
| testExplorerProvider?: boolean; | ||
| openNewWindowProvider?: boolean; | ||
| copyWorksheetOutputProvider?: boolean; | ||
| commandInHtmlFormat?: "vscode" | "sublime"; | ||
| doctorVisibilityProvider?: boolean; |
There was a problem hiding this comment.
I copypasted typescript interface from metals-language-client - I think it's easier to maintain it this way. It's also more accurate because it indicates that these properties are optional and don't have to be set.
dos65
requested changes
Mar 29, 2022
|
@dos65 I removed Subject. I also encourage you to do reviews in metals-vscode and language-client ;) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #3755
needs scalameta/metals-vscode#930
Because
Compilations.scalausesBatchedFunctionto batch multiple requests it's very tempting to add there the callback that will execute doctor refresh. But I didn't want to couple doctor and compilations so I createdSubject, should I just use() => doctor.executeRefreshDoctoras aCompilations'sconstructor argument?