Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update vim docs to no longer point people to coc-metals #3819

Merged
merged 1 commit into from
Apr 27, 2022

Conversation

ckipp01
Copy link
Member

@ckipp01 ckipp01 commented Apr 12, 2022

As of this next release
coc-metals will be officially
deprecated, meaning we shouldn't be pointing people to it in the docs,
and also shouldn't have all the features outlined be coc specific. This
makes those changes.

Note that this is much much more minimal than it previously was. This is
mainly because the docs for nvim-metals are pretty spread out, and I
don't have any intention of duplicating them.

All this is mentioned and linked on the vim page.

@ckipp01
Copy link
Member Author

ckipp01 commented Apr 12, 2022

My plan is to leave this open until we do the next release, and then merge it in right after. I'll wait for #3816 to be merged and then I'll rebase and update the contributing section with some new info specifically for nvim-metals and remove the coc-metals stuff there.

Copy link
Contributor

@ekrich ekrich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have yet to go through the whole setup process - I started but can give feedback when I get further.

docs/editors/vim.md Outdated Show resolved Hide resolved
As of this next release
[coc-metals](https://github.com/scalameta/coc-metals) will be officially
deprecated, meaning we shouldn't be pointing people to it in the docs,
and also shouldn't have all the features outlined be coc specific. This
makes those changes.

Note that this is much much more minimal than it previously was. This is
mainly because the docs for `nvim-metals` are pretty spread out, and I
don't have any intention of duplicating them.

- The main docs are in
  https://github.com/scalameta/nvim-metals/blob/main/doc/metals.txt and
  they are in a specific format necessary for Vim help docs.
- scalameta/nvim-metals#39 holds the
  example configuration
- scalameta/nvim-metals#279 holds the
  feature list and instructions on how to utilize everything.

All this is mentioned and linked on the vim page.
@ckipp01
Copy link
Member Author

ckipp01 commented Apr 27, 2022

Now that the release is done is it alright to merge this?

Copy link
Contributor

@tgodzik tgodzik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ckipp01 ckipp01 merged commit bb0620e into scalameta:main Apr 27, 2022
@ckipp01 ckipp01 deleted the vim-docs branch April 27, 2022 11:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants