Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release: Add release notes for Metals 0.11.8 #4214

Merged
merged 20 commits into from Aug 10, 2022

Conversation

tanishiking
Copy link
Member

No description provided.


## [Scala 2] Auto import types in string interpolations

## More stable code navigation across subprojects
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd like to mention something is improved by #4176
Do you think this is enough, or do you think we don't need to mention it? @kpodsiad

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was wondering about providing screenshots before vs after from some dummy project to show users what kind of errors this might fix 🤔 What do you think?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, providing concrete examples is always a good idea!
However, it might be challenging to describe this change to end-users, so I'm also fine with just telling them something has improved in this version without a screenshot.

Copy link
Member

@ckipp01 ckipp01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some grammar nits.

website/blog/2022-08-01-aluminium.md Outdated Show resolved Hide resolved
website/blog/2022-08-01-aluminium.md Outdated Show resolved Hide resolved
website/blog/2022-08-01-aluminium.md Outdated Show resolved Hide resolved
website/blog/2022-08-01-aluminium.md Outdated Show resolved Hide resolved
website/blog/2022-08-01-aluminium.md Outdated Show resolved Hide resolved
website/blog/2022-08-01-aluminium.md Outdated Show resolved Hide resolved
website/blog/2022-08-01-aluminium.md Outdated Show resolved Hide resolved
Comment on lines 92 to 103
Previously, Metals sometimes fail to code navigation such as find-all-references and go-to-defintions across projects.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMO this doesn't really add anything to the release notes. I think we should either cut this and add to the list of "improvements or bugfixes" or if we think it's important to give it its own section then down below I think we should expand on it instead of just saying it was done and linking the pr.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hm, right I just wanted to shout out because this is a great improvement (from the perspective of someone who knows the Metals internal), but as an end-user, it's just one of the bug fixes.

Maybe we can say "More stable code navigation across subprojects" in TL;DR and do not add a section for it. What do you think about it @kpodsiad ?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would add a bugfixes section or miscellaneous section and put there anything that doesn't require a section

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I decided to just mention this improvement in TL;DR, and not have a section for it. FYI @kpodsiad

  • If we explain the details, I think it is too much about technical details, and I don't think end-users are interested in that.
  • If we omit the details, it says nothing like the section I wrote.
  • I don't think miscellaneous is a good idea, because it's the role of Merged PRs section I guess.

website/blog/2022-08-01-aluminium.md Outdated Show resolved Hide resolved
website/blog/2022-08-01-aluminium.md Outdated Show resolved Hide resolved
website/blog/2022-08-01-aluminium.md Outdated Show resolved Hide resolved
website/blog/2022-08-01-aluminium.md Outdated Show resolved Hide resolved
Copy link
Contributor

@tgodzik tgodzik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot @tanishiking !

website/blog/2022-08-01-aluminium.md Outdated Show resolved Hide resolved
website/blog/2022-08-01-aluminium.md Outdated Show resolved Hide resolved
@tanishiking
Copy link
Member Author

I'm planning to release on next Monday (2022-08-08

tanishiking and others added 19 commits August 9, 2022 21:26
Co-authored-by: Tomasz Godzik <tgodzik@users.noreply.github.com>
Co-authored-by: Chris Kipp <ckipp@pm.me>
Co-authored-by: vzmerr <109077949+vzmerr@users.noreply.github.com>
Co-authored-by: Tomasz Godzik <tgodzik@users.noreply.github.com>
Co-authored-by: vzmerr <109077949+vzmerr@users.noreply.github.com>
Co-authored-by: vzmerr <109077949+vzmerr@users.noreply.github.com>
Co-authored-by: Chris Kipp <ckipp@pm.me>
We're not going to include Scala3 type completion to
Metals release note.

Context:
scalameta#4236
scalameta#4234 (comment)

> Context: scalameta#4234 (comment) we encounter some regressions related to the
> type completions feature.
> We revert those changes because we're going to release a new version of Metals,
> and it would be safer not to include those features in the new release scalameta#4214
@tanishiking
Copy link
Member Author

Updated the release date to 2022-08-10. Let's do some final checks and do release tomorrow 🚀

Tagged 51260e5 as v0.11.8

- regenerate release note
- minor fixes
  - removed `More stable code navigation` from TL;DR
- Set release date to 2022-08-10
Copy link
Contributor

@tgodzik tgodzik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@tanishiking
Copy link
Member Author

Let's go 🚀

@tanishiking tanishiking merged commit 75f6ac2 into scalameta:main Aug 10, 2022
tanishiking added a commit that referenced this pull request Aug 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants