[Scala 3] Revert type completions feature #4236
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tanishiking
added a commit
to tanishiking/metals
that referenced
this pull request
Aug 9, 2022
We're not going to include Scala3 type completion to Metals release note. Context: scalameta#4236 scalameta#4234 (comment) > Context: scalameta#4234 (comment) we encounter some regressions related to the > type completions feature. > We revert those changes because we're going to release a new version of Metals, > and it would be safer not to include those features in the new release scalameta#4214
|
oops, I thought auto-merge requires all CI passes 😅 (I hope they actually pass in |
tanishiking
added a commit
to tanishiking/metals
that referenced
this pull request
Aug 9, 2022
We're not going to include Scala3 type completion to Metals release note. Context: scalameta#4236 scalameta#4234 (comment) > Context: scalameta#4234 (comment) we encounter some regressions related to the > type completions feature. > We revert those changes because we're going to release a new version of Metals, > and it would be safer not to include those features in the new release scalameta#4214
tanishiking
added a commit
to tanishiking/metals
that referenced
this pull request
Aug 9, 2022
This reverts commit 6bf55ab.
tanishiking
added a commit
that referenced
this pull request
Aug 10, 2022
* docs: Add release note for 0.11.8 * chore: update for 0.11.8 * docs: Add gif for auto-complete extension methods * docs: Count closed issue since last release * Apply suggestions from code review Co-authored-by: Tomasz Godzik <tgodzik@users.noreply.github.com> Co-authored-by: Chris Kipp <ckipp@pm.me> * docs: fix grammers / adjust title of sections * docs: Add interpolation completion sections * Apply suggestions from code review Co-authored-by: vzmerr <109077949+vzmerr@users.noreply.github.com> Co-authored-by: Tomasz Godzik <tgodzik@users.noreply.github.com> * Add section for type completion * Improe scaladoc completion section * Apply suggestions from code review Co-authored-by: vzmerr <109077949+vzmerr@users.noreply.github.com> * fix: convert to named parameters title * Add my name * Remove improved code navigation section * Update the tag, and date of release note * Fix the number of new features / closed issues * Apply suggestions from code review Co-authored-by: vzmerr <109077949+vzmerr@users.noreply.github.com> * Apply suggestions from code review Co-authored-by: Chris Kipp <ckipp@pm.me> * docs: Remove type completions from release note We're not going to include Scala3 type completion to Metals release note. Context: #4236 #4234 (comment) > Context: #4234 (comment) we encounter some regressions related to the > type completions feature. > We revert those changes because we're going to release a new version of Metals, > and it would be safer not to include those features in the new release #4214 * Update release note for the latest v0.11.8 tag Tagged 51260e5 as v0.11.8 - regenerate release note - minor fixes - removed `More stable code navigation` from TL;DR - Set release date to 2022-08-10 Co-authored-by: Tomasz Godzik <tgodzik@users.noreply.github.com> Co-authored-by: Chris Kipp <ckipp@pm.me> Co-authored-by: vzmerr <109077949+vzmerr@users.noreply.github.com>
tanishiking
added a commit
that referenced
this pull request
Aug 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR reverts the following changes.
Context: #4234 (comment) we encounter some regressions related to the type completions feature. We revert those changes because we're going to release a new version of Metals, and it would be safer not to include those features in the new release #4214