Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace toLSP occurences by toLsp. #4331

Merged
merged 2 commits into from
Sep 5, 2022
Merged

Replace toLSP occurences by toLsp. #4331

merged 2 commits into from
Sep 5, 2022

Conversation

riiswa
Copy link
Contributor

@riiswa riiswa commented Sep 1, 2022

Related to #4330.

tanishiking
tanishiking approved these changes Sep 2, 2022
View reviewed changes
Copy link
Member

@tanishiking tanishiking left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM from me, what do y'all think?
(I personally don't care LSP or Lsp, but stick to one of them is good 👍)

@tgodzik
Copy link
Contributor

tgodzik commented Sep 2, 2022

LGTM from me, what do y'all think? (I personally don't care LSP or Lsp, but stick to one of them is good +1)

Same as me.

@tanishiking tanishiking merged commit f674cb9 into scalameta:main Sep 5, 2022
@tanishiking tanishiking mentioned this pull request Sep 5, 2022
Closed
@kpodsiad
Copy link
Member

kpodsiad commented Sep 5, 2022

I'm responsible for raising this issue, but then I realized that most toLsp methods (if not all of them) was made by me 😅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tgodzik tgodzik tgodzik approved these changes

@tanishiking tanishiking tanishiking approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@riiswa @tgodzik @kpodsiad @tanishiking