bugfix: Allow to add jvmopts and env variables when running tests

[tgodzik]

Previously, only the test suite name was sent via BSP. Now we also add env variables and jvmopts.

Fixes #4374

[dos65]

Just a question.

Is it bloop only?
I haven't found these params in build-server-protocol

[kpodsiad]

no, it's both bloop and sbt (all build servers which support debugging) - build-server-protocol/build-server-protocol#304

[dos65]

thx for explanation!

[kpodsiad]

LGTM
btw, it's not really a bugfix, more like a improvement ;)

[kpodsiad]

Hmm, I wonder if this logic should also be applied to the requests from the Test Explorer.

metals/metals/src/main/scala/scala/meta/internal/metals/debug/DebugProvider.scala

Lines 568 to 592 in 42c5b16

	def resolveTestSelectionParams(
	request: ScalaTestSuitesDebugRequest
	)(implicit ec: ExecutionContext): Future[b.DebugSessionParams] = {
	val makeDebugSession = () =>
	buildTargets.info(request.target) match {
	case Some(buildTarget) =>
	val debugSession =
	if (supportsTestSelection(request.target))
	new b.DebugSessionParams(
	singletonList(buildTarget.getId),
	DebugProvider.ScalaTestSelection,
	request.requestData.toJson,
	)
	else
	new b.DebugSessionParams(
	singletonList(buildTarget.getId),
	b.DebugSessionParamsDataKind.SCALA_TEST_SUITES,
	request.requestData.suites.map(_.className).toJson,
	)
	Future.successful(debugSession)
	case None =>
	val error = BuildTargetNotFoundException(request.target.getUri)
	reportErrors(error)
	Future.failed(error)
	}

[tgodzik]

Hmm, I wonder if this logic should also be applied to the requests from the Test Explorer.

metals/metals/src/main/scala/scala/meta/internal/metals/debug/DebugProvider.scala

Lines 568 to 592 in 42c5b16

	def resolveTestSelectionParams(
	request: ScalaTestSuitesDebugRequest
	)(implicit ec: ExecutionContext): Future[b.DebugSessionParams] = {
	val makeDebugSession = () =>
	buildTargets.info(request.target) match {
	case Some(buildTarget) =>
	val debugSession =
	if (supportsTestSelection(request.target))
	new b.DebugSessionParams(
	singletonList(buildTarget.getId),
	DebugProvider.ScalaTestSelection,
	request.requestData.toJson,
	)
	else
	new b.DebugSessionParams(
	singletonList(buildTarget.getId),
	b.DebugSessionParamsDataKind.SCALA_TEST_SUITES,
	request.requestData.suites.map(_.className).toJson,
	)
	Future.successful(debugSession)
	case None =>
	val error = BuildTargetNotFoundException(request.target.getUri)
	reportErrors(error)
	Future.failed(error)
	}

Can you set addtional options for Test Explorer?

[kpodsiad]

Can you set addtional options for Test Explorer?

There is some mechanism for configuration/options but currently vscode doesn't use it. Sounds like an improvement.