Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: match completion with -no-indent option #4639

Merged
merged 1 commit into from
Nov 22, 2022
Merged

fix: match completion with -no-indent option #4639

merged 1 commit into from
Nov 22, 2022

Conversation

jkciesluk
Copy link
Member

fixes #4624

tgodzik
tgodzik requested changes Nov 14, 2022
View reviewed changes
Copy link
Contributor

@tgodzik tgodzik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! Could you run scalafix and rebase?

Also, let's follow up for the extract-method code action, which I think will have a similar issue.

tests/cross/src/test/scala/tests/pc/CompletionMatchSuite.scala Outdated Show resolved Hide resolved
tgodzik
tgodzik approved these changes Nov 22, 2022
View reviewed changes
Copy link
Contributor

@tgodzik tgodzik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@tgodzik tgodzik merged commit c4f0f91 into scalameta:main Nov 22, 2022
@jkciesluk jkciesluk deleted the i4624 branch November 22, 2022 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tgodzik tgodzik tgodzik approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

The match snippet always creates a braceless expression in Scala 3, even when -no-indent compiler flag is on
2 participants
@jkciesluk @tgodzik