Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Don't show wildcard param completions #4665

Merged
merged 1 commit into from
Nov 21, 2022
Merged

Conversation

jkciesluk
Copy link
Member

@jkciesluk jkciesluk commented Nov 21, 2022

fixes #4657

@jkciesluk jkciesluk marked this pull request as draft November 21, 2022 12:50
@jkciesluk jkciesluk marked this pull request as ready for review November 21, 2022 14:49
@jkciesluk
Copy link
Member Author

There is still a similar issue in

List((1,2), (3,4)).map { (ab, _) =>
    @@
  }

We get completion x$1.

List((1,2), (3,4)).map { (ab, _) =>
    x$1
  }

It actually compiles, but this can be a bug in dotty. I will open an issue and add a link here

Copy link
Contributor

@tgodzik tgodzik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

I looked into whether we could check it a bit better, but it seems it's the most straightforward way.

@tgodzik tgodzik merged commit 9bbcda0 into scalameta:main Nov 21, 2022
@kubukoz
Copy link
Contributor

kubukoz commented Nov 21, 2022

that was quick!

I'm just curious, I thought completions for Scala 3 came from the compiler... can you give me some context on that?

@jkciesluk
Copy link
Member Author

Most completions come from the compiler, but we add some more advanced ones, like completions for overriding methods, exhaustive match completion or completions for workspace symbols and extension methods (completions requiring adding an import) etc.

@jkciesluk jkciesluk deleted the i4567 branch November 22, 2022 09:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

(Scala 3) invalid symbols in completions
3 participants