Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Add release notes for Metals 0.11.10 #4740

Merged
merged 1 commit into from Jan 2, 2023

Conversation

tgodzik
Copy link
Contributor

@tgodzik tgodzik commented Dec 16, 2022

Let me know if anyone wants to fill in a section. In the meantime I am looking at some issue with Bloop that seem to be happening for me on JDK 8 and scalameta issue with diagnostics

@tgodzik tgodzik force-pushed the release-notes-0.11.10 branch 2 times, most recently from 0ae6e63 to e0cbe06 Compare December 28, 2022 17:19
website/blog/2023-01-02-aluminium.md Outdated Show resolved Hide resolved
website/blog/2023-01-02-aluminium.md Outdated Show resolved Hide resolved
website/blog/2023-01-02-aluminium.md Outdated Show resolved Hide resolved
website/blog/2023-01-02-aluminium.md Outdated Show resolved Hide resolved
website/blog/2023-01-02-aluminium.md Outdated Show resolved Hide resolved
website/blog/2023-01-02-aluminium.md Show resolved Hide resolved
website/blog/2023-01-02-aluminium.md Outdated Show resolved Hide resolved
website/blog/2023-01-02-aluminium.md Outdated Show resolved Hide resolved
website/blog/2023-01-02-aluminium.md Outdated Show resolved Hide resolved
website/blog/2023-01-02-aluminium.md Outdated Show resolved Hide resolved
@tgodzik tgodzik force-pushed the release-notes-0.11.10 branch 2 times, most recently from 9ee0133 to 40a2cbd Compare December 29, 2022 18:45
@tgodzik
Copy link
Contributor Author

tgodzik commented Dec 29, 2022

@ckipp01 I think I addressed most of your comments and the release notes are mostly finished. Let me know what you think!

Copy link
Member

@jkciesluk jkciesluk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some small typos, otherwise looks good!

website/blog/2023-01-02-aluminium.md Outdated Show resolved Hide resolved
website/blog/2023-01-02-aluminium.md Outdated Show resolved Hide resolved
website/blog/2023-01-02-aluminium.md Outdated Show resolved Hide resolved
website/blog/2023-01-02-aluminium.md Outdated Show resolved Hide resolved
Copy link
Member

@ckipp01 ckipp01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So much great stuff in here. Just a small couple grammar nits, but other than that LGTM! Great work @tgodzik!

website/blog/2023-01-02-aluminium.md Outdated Show resolved Hide resolved
website/blog/2023-01-02-aluminium.md Outdated Show resolved Hide resolved
within Visual Studio Code and nvim-metals which use an additional Test Explorer
that is not available for all the editors. However, thanks to
([LaurenceWarne](https://github.com/LaurenceWarne)) Metals will now show lenses
to run a single test case in case of all other editors.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does it make sense to mention frameworks which are supported?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe? Though we should probably have that in the docs in reality

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should probably have that in the docs in reality

Good point

@tgodzik
Copy link
Contributor Author

tgodzik commented Jan 2, 2023

If no one is against it I will start a release in circa 1 hour.

@ckipp01 ckipp01 added tech debt We should have addressed this yesterday and removed tech debt We should have addressed this yesterday labels Jan 2, 2023
@tgodzik
Copy link
Contributor Author

tgodzik commented Jan 2, 2023

It's running! https://github.com/scalameta/metals/actions/runs/3823126261 🚀

@tgodzik tgodzik merged commit 4aa438b into scalameta:main Jan 2, 2023
@tgodzik tgodzik deleted the release-notes-0.11.10 branch January 2, 2023 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants