bugfix: navigation for apply function in a companion object #4914
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously: ScalaMtags indexer would not take notice of the automatically created apply function that is produced in a companion object for a case class. This lead to the disambiguator counter to be off by one and goto pointing to the wrong reference. Now: we make sure that classes are indexed before objects and record found case class to fix the disambiguator counter for apply.
kasiaMarek
force-pushed
the
goto-object-apply
branch
from
25d3fac
to
d634bdd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously: ScalaMtags indexer would not take notice of the automatically created apply function that is produced in a companion object for a case class. This lead to the disambiguator counter to be off by one and goto pointing to the wrong reference.
Now: we make sure that classes are indexed before objects and record found case class to fix the disambiguator counter for apply.
resolves #4769