improvement: Make fallback semantic tokens readonly #5067
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I've changed |
jkciesluk
force-pushed
the
sem-def-ro
branch
3 times, most recently
from
8875d8d
to
b9ecd94
Compare
tgodzik
reviewed
Mar 29, 2023
| val tokenModifier: Int = | ||
| tokenType match { | ||
| case _ if tokenType == getTypeId(SemanticTokenTypes.Variable) => | ||
| 1 << getModifierId(SemanticTokenModifiers.Readonly) |
There was a problem hiding this comment.
Shouldn't we add readonly only in the fallback?
There was a problem hiding this comment.
This is for cases when token isn't an ident, but it becomes variable. For now, the only case for that is underscore, which is almost always readonly.
tgodzik
approved these changes
Mar 30, 2023
jkciesluk
force-pushed
the
sem-def-ro
branch
2 times, most recently
from
c9dac0b
to
1c7aea8
Compare
When we can't match any node with scalameta ident token, we make it either `class` or `variable`, if it starts with upper or lower case. Now this `variable` will have `readonly` modifier, since it's rarely mutable (e.g. self types, wildcard imports).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we can't match any node with scalameta ident token, we make it either
classorvariable, if it starts with upper or lower case. Now thisvariablewill havereadonlymodifier, since it's rarely mutable (e.g. self types, wildcard imports).Solves #5052