Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix select dynamic hover tests for 3.3.1-RC1 #5068

Merged
merged 1 commit into from
Mar 20, 2023

Conversation

jkciesluk
Copy link
Member

Path for selectDynamic changed, now it starts with Select(_, selectDynamic). We had to adjust fallbackToDynamics to match also new path. Also, now MetalsInteractive.enclosingSymbolsWithExpressionType returns selectDynamic symbol.

Fixes nightly cross tests.

Path for selectDynamic changed, now it starts with Select(_, selectDynamic).
We had to adjust `fallbackToDynamics` to match also new path.
Also, now  `MetalsInteractive.enclosingSymbolsWithExpressionType` returns `selectDynamic` symbol.
@jkciesluk jkciesluk requested a review from tgodzik March 20, 2023 10:17
Copy link
Contributor

@tgodzik tgodzik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tgodzik tgodzik merged commit 5d84193 into scalameta:main Mar 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants