bugfix: Catch exception from the compiler when coursier api is on cla… #5586
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tgodzik
commented
Aug 25, 2023
mtags/src/main/scala-3/scala/meta/internal/pc/CompilerSearchVisitor.scala
Show resolved
Hide resolved
…sspath We previously fixed another issue connected to this, when no completions would be available because `isPublic` would throw an exception. Now, it turns out we needed to wrap `toSymbols` methods, otherwise we would not get the duplicated symbols (which are also shadowed) Connected to scala/scala3#16175
tgodzik
force-pushed
the
coursier-error
branch
from
58ff9f4
to
339f757
Compare
jkciesluk
approved these changes
Aug 28, 2023
kasiaMarek
approved these changes
Aug 28, 2023
mtags/src/main/scala-3/scala/meta/internal/pc/CompilerSearchVisitor.scala
Show resolved
Hide resolved
tgodzik
added a commit
to tgodzik/dotty
that referenced
this pull request
Sep 1, 2023
tgodzik
added a commit
to scala/scala3
that referenced
this pull request
Sep 6, 2023
WojciechMazur
pushed a commit
to scala/scala3
that referenced
this pull request
Jun 19, 2024
Fixed in Metals: scalameta/metals#5586 [Cherry-picked fa54869]
WojciechMazur
pushed a commit
to scala/scala3
that referenced
this pull request
Jun 19, 2024
Fixed in Metals: scalameta/metals#5586 [Cherry-picked fa54869]
WojciechMazur
pushed a commit
to scala/scala3
that referenced
this pull request
Jun 19, 2024
Fixed in Metals: scalameta/metals#5586 [Cherry-picked fa54869]
WojciechMazur
pushed a commit
to scala/scala3
that referenced
this pull request
Jun 19, 2024
Fixed in Metals: scalameta/metals#5586 [Cherry-picked fa54869]
WojciechMazur
pushed a commit
to scala/scala3
that referenced
this pull request
Jun 19, 2024
Fixed in Metals: scalameta/metals#5586 [Cherry-picked fa54869]
WojciechMazur
pushed a commit
to scala/scala3
that referenced
this pull request
Jun 19, 2024
Fixed in Metals: scalameta/metals#5586 [Cherry-picked fa54869]
WojciechMazur
pushed a commit
to scala/scala3
that referenced
this pull request
Jun 19, 2024
Fixed in Metals: scalameta/metals#5586 [Cherry-picked fa54869]
WojciechMazur
pushed a commit
to scala/scala3
that referenced
this pull request
Jun 19, 2024
Fixed in Metals: scalameta/metals#5586 [Cherry-picked fa54869]
WojciechMazur
pushed a commit
to scala/scala3
that referenced
this pull request
Jun 19, 2024
Fixed in Metals: scalameta/metals#5586 [Cherry-picked fa54869]
WojciechMazur
pushed a commit
to scala/scala3
that referenced
this pull request
Jun 19, 2024
Fixed in Metals: scalameta/metals#5586 [Cherry-picked fa54869]
WojciechMazur
pushed a commit
to scala/scala3
that referenced
this pull request
Jun 19, 2024
Fixed in Metals: scalameta/metals#5586 [Cherry-picked fa54869]
WojciechMazur
pushed a commit
to scala/scala3
that referenced
this pull request
Jun 19, 2024
Fixed in Metals: scalameta/metals#5586 [Cherry-picked fa54869]
WojciechMazur
pushed a commit
to scala/scala3
that referenced
this pull request
Jun 19, 2024
Fixed in Metals: scalameta/metals#5586 [Cherry-picked fa54869]
WojciechMazur
pushed a commit
to scala/scala3
that referenced
this pull request
Jun 19, 2024
Fixed in Metals: scalameta/metals#5586 [Cherry-picked fa54869]
WojciechMazur
pushed a commit
to scala/scala3
that referenced
this pull request
Jun 19, 2024
Fixed in Metals: scalameta/metals#5586 [Cherry-picked fa54869]
WojciechMazur
pushed a commit
to scala/scala3
that referenced
this pull request
Jun 19, 2024
Fixed in Metals: scalameta/metals#5586 [Cherry-picked fa54869]
WojciechMazur
pushed a commit
to scala/scala3
that referenced
this pull request
Jun 19, 2024
Fixed in Metals: scalameta/metals#5586 [Cherry-picked fa54869]
WojciechMazur
pushed a commit
to scala/scala3
that referenced
this pull request
Jun 19, 2024
Fixed in Metals: scalameta/metals#5586 [Cherry-picked fa54869]
WojciechMazur
pushed a commit
to scala/scala3
that referenced
this pull request
Jun 19, 2024
Fixed in Metals: scalameta/metals#5586 [Cherry-picked fa54869]
WojciechMazur
pushed a commit
to scala/scala3
that referenced
this pull request
Jun 19, 2024
Fixed in Metals: scalameta/metals#5586 [Cherry-picked fa54869]
WojciechMazur
pushed a commit
to scala/scala3
that referenced
this pull request
Jun 19, 2024
Fixed in Metals: scalameta/metals#5586 [Cherry-picked fa54869]
WojciechMazur
pushed a commit
to scala/scala3
that referenced
this pull request
Jun 19, 2024
Fixed in Metals: scalameta/metals#5586 [Cherry-picked fa54869]
WojciechMazur
pushed a commit
to scala/scala3
that referenced
this pull request
Jun 20, 2024
Fixed in Metals: scalameta/metals#5586 [Cherry-picked fa54869]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…sspath
We previously fixed another issue connected to this, when no completions would be available because
isPublicwould throw an exception. Now, it turns out we needed to wraptoSymbolsmethods, otherwise we would not get the duplicated symbols (which are also shadowed)Connected to scala/scala3#16175