Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bugfix: Catch exception from the compiler for broken shadowed pickles #18502

Merged
merged 1 commit into from
Sep 6, 2023
Merged

bugfix: Catch exception from the compiler for broken shadowed pickles #18502

merged 1 commit into from
Sep 6, 2023

Conversation

tgodzik
Copy link
Contributor

@tgodzik tgodzik commented Sep 1, 2023

Fixed in Metals: scalameta/metals#5586

@tgodzik tgodzik added backport:nominated If we agree to backport this PR, replace this tag with "backport:accepted", otherwise delete it. area:presentation-compiler Related to the presentation compiler module used by Metals and possibly other tools labels Sep 1, 2023
@tgodzik tgodzik requested a review from rochala September 1, 2023 17:57
@tgodzik tgodzik merged commit 5eb73b6 into scala:main Sep 6, 2023
17 checks passed
@tgodzik tgodzik deleted the followup branch September 6, 2023 08:12
@Kordyjan Kordyjan removed the backport:nominated If we agree to backport this PR, replace this tag with "backport:accepted", otherwise delete it. label Oct 10, 2023
@Kordyjan Kordyjan added this to the 3.4.0 milestone Dec 20, 2023
@WojciechMazur WojciechMazur mentioned this pull request Jun 19, 2024
Merged
WojciechMazur added a commit that referenced this pull request Jun 20, 2024
@WojciechMazur
Backport "bugfix: Catch exception from the compiler for broken shadow…
46a96c0 
…ed pickles" to LTS (#20611)

Backports #18502 to the LTS branch.

PR submitted by the release tooling.
[skip ci]
@WojciechMazur WojciechMazur mentioned this pull request Jun 20, 2024
Merged
WojciechMazur added a commit that referenced this pull request Jun 20, 2024
@WojciechMazur
Backport "bugfix: Catch exception from the compiler for broken shadow…
3e8f537 
…ed pickles" to LTS (#20670)

Backports #18502 to the LTS branch.

PR submitted by the release tooling.
[skip ci]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rochala rochala rochala approved these changes

Assignees

@rochala rochala

Labels
area:presentation-compiler Related to the presentation compiler module used by Metals and possibly other tools
Projects
None yet
Milestone
3.4.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@tgodzik @rochala @Kordyjan