Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: workaround for wrong span in hover scala 3.3.1 #5882

Merged
merged 1 commit into from Nov 28, 2023

Conversation

kasiaMarek
Copy link
Contributor

@kasiaMarek kasiaMarek commented Nov 27, 2023

Connected to: #5869. This is fixed in dotty (probably the incorrect position was fixed in the compiler) and works for current nightly.

@kasiaMarek kasiaMarek changed the title fix: workaourd for wrong span in hover scala 3.3.1 fix: workaround for wrong span in hover scala 3.3.1 Nov 27, 2023
Copy link
Member

@jkciesluk jkciesluk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Contributor

@tgodzik tgodzik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@tgodzik tgodzik merged commit fdb0a99 into scalameta:main Nov 28, 2023
23 of 25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants