Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bugfix: hover for select chains ending with function Scala 2 #5883

Merged
merged 2 commits into from Nov 30, 2023
Merged

bugfix: hover for select chains ending with function Scala 2 #5883

merged 2 commits into from Nov 30, 2023

Conversation

kasiaMarek
Copy link
Contributor

resolves: #5869

@kasiaMarek kasiaMarek changed the title bugfix: hover for select chains ending with function bugfix: hover for select chains ending with function Scala 2 Nov 27, 2023
@kasiaMarek kasiaMarek marked this pull request as ready for review November 28, 2023 10:19
@kasiaMarek kasiaMarek requested review from jkciesluk and tgodzik and removed request for tgodzik and jkciesluk November 28, 2023 10:35
@kasiaMarek kasiaMarek marked this pull request as draft November 28, 2023 10:50
@kasiaMarek kasiaMarek marked this pull request as ready for review November 28, 2023 13:01
jkciesluk
jkciesluk approved these changes Nov 28, 2023
View reviewed changes
Copy link
Member

@jkciesluk jkciesluk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

tgodzik
tgodzik approved these changes Nov 28, 2023
View reviewed changes
Copy link
Contributor

@tgodzik tgodzik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Should we keep the issue open for Scala 3?

@kasiaMarek
Copy link
Contributor Author

LGTM! Should we keep the issue open for Scala 3?

No, handled in #5882. I deleted the ignore tags now.

@kasiaMarek kasiaMarek merged commit d5889c8 into scalameta:main Nov 30, 2023
23 of 25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tgodzik tgodzik tgodzik approved these changes

@jkciesluk jkciesluk jkciesluk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Hover doesn't work in some cases (deep call chain with terse syntax)
3 participants
@kasiaMarek @tgodzik @jkciesluk