Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Outline compiler #6114
Outline compiler #6114
Changes from all commits
2c1ad9f
d5d5857
401d6bf
8d9d235
7e4b45e
1c161df
28a6f7a
61cd2e2
466786d
73f961a
ce23987
a4e9146
31366b7
aee71d8
94e7008
31b3282
ff0420b
3dfc44a
1267738
5a327c4
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Large diffs are not rendered by default.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is this id? Should we use BuildTargetIdentifier here? Or at least add an alias.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is
BuildTargetIdentifier
, I'm constructing it here.It's just that it comes as a string from pc (can't be
BuildTargetIdentifier
, because pc interface doesn't depend onbsp4j
) and it's less boilerplate to map it here instead of each place inCompilers
.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note: that this doesn't account for possible changes before compilation end is reported, it may not 100% reflect the state of files that was during compilation.