Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make presentation compiler work on 2.12.9 #872

Merged
merged 3 commits into from Aug 25, 2019
Merged

Make presentation compiler work on 2.12.9 #872

merged 3 commits into from Aug 25, 2019

Commits on Aug 24, 2019

  1. Remove an optimization that breaks the PC on 2.12.9 

    The optimizations avoids re-downloading semanticdb-scalac-core (which is
a transitive dependency of mtags) if the semanticdb-scalac plugin is already
installed.

For reasons that we haven't yet investigated, this breaks the PC-based
features on 2.12.9, throwing this exception:

```
Exception in thread "pool-12-thread-2" java.lang.AbstractMethodError:
Method scala/meta/internal/pc/MetalsGlobal$$anon$1.scala$tools$nsc$typechecker$Contexts$_setter_$scala$tools$nsc$typechecker$Contexts$$symbolLookupCache_$eq(Lscala/reflect/internal/util/ReusableInstance;)V is abstract
```

Since the optimization is clearly breaking semantics, we remove it for now.
    @gabro
    gabro committed Aug 24, 2019
    Copy the full SHA
    ffe0f50 View commit details
    Browse the repository at this point in the history

  2. Fix 2.12.9 recommendation 

    We don't use BuildInfo.scala212 since Metals itself has not migrated to
2.12.9 yet.
    @gabro
    gabro committed Aug 24, 2019
    Copy the full SHA
    8bad2ba View commit details
    Browse the repository at this point in the history

  3. Also publishLocal mtags-interfaces before slow tests

    @gabro
    gabro committed Aug 24, 2019
    Copy the full SHA
    1db7e49 View commit details
    Browse the repository at this point in the history