Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove documentation on how to setup test reports. #305

Closed
wants to merge 1 commit into from

Conversation

olafurpg
Copy link
Member

@olafurpg olafurpg commented Feb 4, 2021

The test reports feature stopped working after my Google Cloud trial
expired. I never used the test reports so it's easier to remove them
instead of updating the GCP credentials.

The test reports feature stopped working after my Google Cloud trial
expired. I never used the test reports so it's easier to remove them
instead of updating the GCP credentials.
@olafurpg olafurpg closed this Feb 4, 2021
@olafurpg
Copy link
Member Author

olafurpg commented Feb 4, 2021

Merged this into main.

@gabro
Copy link
Member

gabro commented Feb 4, 2021

Can I ask why? The instructions were valid anyway, no?

(I'm asking since I think the feature is pretty cool and I was gonna talk about it in my upcoming talk :D )

@tgodzik
Copy link
Contributor

tgodzik commented Feb 4, 2021

We should be able to just use the reports with different credentials, I managed to set it up in Metals, so let's at least leave the docs. We can remove the reports from munit if they are unused.

@olafurpg
Copy link
Member Author

olafurpg commented Feb 5, 2021

I’m sorry I rushed too quickly to merge this. I’m ok with adding the page back. My impression was only that this feature is not used much. I generally want to avoid documenting functionality that’s half complete.

@gabro gabro mentioned this pull request Apr 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants