-
Notifications
You must be signed in to change notification settings - Fork 276
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
java.lang.NoClassDefFoundError: scala/reflect/api/Symbols$SymbolApi #492
Comments
Can you reproduce the error with the CLI? There now a bash script that can auto-upgrade: https://olafurpg.github.io/scalafmt/#Linux/OSX |
@olafurpg , yep,
|
This must caused be the lack of scala-reflect after removing the old style macros in #491 Seems like 0.4.3 will be shortlived, thanks for reporting! |
@timothyklim Could you give me a minimal code example to reproduce? I want to add it to the test suite, I am surprised this didn't pop up up formatting >1 million LOC. |
@olafurpg Aha, I missed object A {
<.section(render(props)
} |
Interesting! It only appears on parse errors, that might explain why it wasn't caught in the tests. Maybe we can entirely drop scala-reflect then, it makes the fat jar 4mb smaller :)) |
Once scalameta/scalameta#502 is fixed, we can remove scala-reflect. Crazy enough, I wasn't able to reproduce the error via SBT so now I have a bash script to ensure the same doesn't happen again.
Once scalameta/scalameta#502 is fixed, we can remove scala-reflect. Crazy enough, I wasn't able to reproduce the error via SBT so now I have a bash script to ensure the same doesn't happen again.
Once scalameta/scalameta#502 is fixed, we can remove scala-reflect. Crazy enough, I wasn't able to reproduce the error via SBT so now I have a bash script to ensure the same doesn't happen again.
Alright, this should be fixed in the next release which I hope to get out tomorrow. I'm surprised I wasn't able to reproduce the error via SBT, not even if I ran a main function in the core library. Plain old bash integration test it is then :) |
@olafurpg, Thank you! Will try tomorrow 😄 |
Once scalameta/scalameta#502 is fixed, we can remove scala-reflect. Crazy enough, I wasn't able to reproduce the error via SBT so now I have a bash script to ensure the same doesn't happen again.
I'm using the
reformatOnCompileSettings
settings and I got a strange error when I tried to upgradesbt-scalafmt
from 0.4.3-RC1 to 0.4.3:The text was updated successfully, but these errors were encountered: