Use Coursier defaults, which also adds support for COURSIER_REPOSITORIES #1524
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
henricook
changed the title
henricook
force-pushed
the
coursier-repositories
branch
from
42285dd
to
a5c102f
Compare
tanishiking
approved these changes
Oct 11, 2019
| ) | ||
| private def repositories: Array[Repository] = { | ||
| // Default repositories are ivy2local, central and also anything in COURSIER_REPOSITORIES overrides | ||
| Repository.defaults().asScala.toArray ++ Array( |
There was a problem hiding this comment.
|
Thanks @tanishiking ! We're super keen to use this, are there nightly builds still? and/or when do you next plan to release? Thanks both for the speedy review |
|
OK! Since this PR is merged, It would be good timing for releasing 2.1.1, and I'll release it now :) |
|
Ultimate speed 💪 - thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is another crack at #1436 which I think is a bit easier now we've got the Coursier interface on board.
I believe that fetching Coursier's default repositories also prompts Couriser to check COURSIER_REPOSITORIES env var and
couriser.repositoriesproperty - so by using defaults here we get COURSIER_REPOSITORIES compatibilityPreviously the default repositories were being totally overwritten by the hard coded repository list
I believe this fulfils #1521