Add support to query type of a term #1212

olafurpg · 2018-01-17T13:03:20Z

Currently, SemanticDB supports the ability to query for types of identifiers but not more complex terms like List(1). This is required to implement certain scalafix linter rules like

Rewrite to use auto-tupling New Rule: DottyAutoTuplingFunctionArgs (semantic) scalacenter/scalafix#556 (comment) We currently can't tell the type of the argument being deconstructed in patterns like List(1 -> 2).map { case (a, b) => "" }
DiscardedUnit [WIP] New Rule: DiscardedValues scalacenter/scalafix#554

The text was updated successfully, but these errors were encountered:

olafurpg · 2018-06-25T11:27:58Z

Related #1533

This is incomplete since, it's blocked by scalameta/scalameta#1212 (Add support to query type of a term) iset: immutable.Set[Int] cset: collecion.Set[Int] both have +/- implemented via SetLike given iset + 1 cset + 1 we know that + is from SetLike, but it's not possible to get the type of iset/cset

scalafix allow us to match on SetLike.+ but we cannot check the type of the expression on the lhs We can work arround this limitation if the lhs is a identifier (simple case). This allow us to document the expected type on the lhs and prepare the implementation once scalameta/scalameta#1212 is resolved

This is incomplete since, it's blocked by scalameta/scalameta#1212 (Add support to query type of a term) iset: immutable.Set[Int] cset: collecion.Set[Int] both have +/- implemented via SetLike given iset + 1 cset + 1 we know that + is from SetLike, but it's not possible to get the type of iset/cset

scalafix allow us to match on SetLike.+ but we cannot check the type of the expression on the lhs We can work arround this limitation if the lhs is a identifier (simple case). This allow us to document the expected type on the lhs and prepare the implementation once scalameta/scalameta#1212 is resolved

This is incomplete since, it's blocked by scalameta/scalameta#1212 (Add support to query type of a term) iset: immutable.Set[Int] cset: collecion.Set[Int] both have +/- implemented via SetLike given iset + 1 cset + 1 we know that + is from SetLike, but it's not possible to get the type of iset/cset Rewrite collection.Set.+ restrict type of lhs scalafix allow us to match on SetLike.+ but we cannot check the type of the expression on the lhs We can work arround this limitation if the lhs is a identifier (simple case). This allow us to document the expected type on the lhs and prepare the implementation once scalameta/scalameta#1212 is resolved

Terms don't have type in scalameta yet: scalameta/scalameta#1212 The SymbolMatcher is not enought for those rules since we need to check the type of the lhs. One workarround is to jump to the symbol if we see an identifier on the lhs. for example: iset: immutable.Set[Int] // ... iset + 1 we can jump to the symbol of iset and get it's type. This is really fragile, since it's not going to work if we have aliases/subtyping. However, it's useful to create those rules, since when we are unblock by scalameta#1212 it's trivial to add the remaining piece

This is incomplete since, it's blocked by scalameta/scalameta#1212 (Add support to query type of a term) iset: immutable.Set[Int] cset: collecion.Set[Int] both have +/- implemented via SetLike given iset + 1 cset + 1 we know that + is from SetLike, but it's not possible to get the type of iset/cset Rewrite collection.Set.+ restrict type of lhs scalafix allow us to match on SetLike.+ but we cannot check the type of the expression on the lhs We can work arround this limitation if the lhs is a identifier (simple case). This allow us to document the expected type on the lhs and prepare the implementation once scalameta/scalameta#1212 is resolved

Terms don't have type in scalameta yet: scalameta/scalameta#1212 The SymbolMatcher is not enought for those rules since we need to check the type of the lhs. One workarround is to jump to the symbol if we see an identifier on the lhs. for example: iset: immutable.Set[Int] // ... iset + 1 we can jump to the symbol of iset and get it's type. This is really fragile, since it's not going to work if we have aliases/subtyping. However, it's useful to create those rules, since when we are unblock by scalameta#1212 it's trivial to add the remaining piece

This is incomplete since, it's blocked by scalameta/scalameta#1212 (Add support to query type of a term) iset: immutable.Set[Int] cset: collecion.Set[Int] both have +/- implemented via SetLike given iset + 1 cset + 1 we know that + is from SetLike, but it's not possible to get the type of iset/cset Rewrite collection.Set.+ restrict type of lhs scalafix allow us to match on SetLike.+ but we cannot check the type of the expression on the lhs We can work arround this limitation if the lhs is a identifier (simple case). This allow us to document the expected type on the lhs and prepare the implementation once scalameta/scalameta#1212 is resolved

Terms don't have type in scalameta yet: scalameta/scalameta#1212 The SymbolMatcher is not enought for those rules since we need to check the type of the lhs. One workarround is to jump to the symbol if we see an identifier on the lhs. for example: iset: immutable.Set[Int] // ... iset + 1 we can jump to the symbol of iset and get it's type. This is really fragile, since it's not going to work if we have aliases/subtyping. However, it's useful to create those rules, since when we are unblock by scalameta#1212 it's trivial to add the remaining piece

olafurpg added the Semantic label Jan 17, 2018

olafurpg mentioned this issue Jan 19, 2018

[WIP] New Rule: DiscardedValues scalacenter/scalafix#554

Closed

xeno-by mentioned this issue Jan 29, 2018

Term.tpe #611

Closed

6 tasks

xeno-by added Symtab and removed Semantic labels Feb 9, 2018

This was referenced Apr 11, 2018

Add support for denotation by tree #1311

Closed

detect toString (and other) calls on primitive values #1488

Closed

This was referenced Jun 25, 2018

Rewrite collection.{Map, Set}.+ and collection.Set.- scala/scala-collection-compat#58

Closed

Rewrite Map.zip -> Map.zip.toMap scala/scala-collection-compat#62

Closed

MasseGuillaume mentioned this issue Jul 27, 2018

Add SortedSet.unsorted and SortedMap.unsorted scala/scala-collection-compat#95

Open

russellremple mentioned this issue Aug 16, 2020

Suppress wartremover warnings rallyhealth/weePickle#40

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add support to query type of a term #1212

Add support to query type of a term #1212

olafurpg commented Jan 17, 2018 •

edited

olafurpg commented Jun 25, 2018

Add support to query type of a term #1212

Add support to query type of a term #1212

Comments

olafurpg commented Jan 17, 2018 • edited

olafurpg commented Jun 25, 2018

olafurpg commented Jan 17, 2018 •

edited