Rewrite collection.{Map, Set}.+ and collection.Set.- #58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MasseGuillaume
changed the title
|
related: scala/bug#10957 |
julienrf
reviewed
Jun 25, 2018
| import scala.collection | ||
| import scala.collection.immutable | ||
| import scala.collection.mutable.{Map, Set} // Challenge to make shure the scoping is correct |
| (iset + 2 + 3).toString | ||
| iset + 2 + 3 - 4 | ||
| iset + 1 - 2 | ||
| cset ++ _root_.scala.collection.Set(1) -- _root_.scala.collection.Set(2) |
There was a problem hiding this comment.
It seems to be working. Can you elaborate on what’s missing?
MasseGuillaume
commented
Jun 25, 2018
| imap + (2 -> 3) + (3 -> 4) | ||
| (iset + 2 + 3).toString | ||
| iset + 2 + 3 - 4 | ||
| iset + 1 - 2 |
There was a problem hiding this comment.
@julienrf this test fails ^
MasseGuillaume
force-pushed
the
c-map-set-plus
branch
from
5b8efb3
to
0d63ea8
Compare
MasseGuillaume
changed the title
julienrf
reviewed
Jun 25, 2018
| } | ||
|
|
||
| final class TypeMatcher(symbol: Symbol)(implicit index: SemanticdbIndex) { | ||
| def unapply(tree: Tree): Option[Unit] = { |
There was a problem hiding this comment.
FYI you can make it return a Boolean rather than an Option[Unit]. Then at use site just write case CollectionSet() =>
MasseGuillaume
force-pushed
the
c-map-set-plus
branch
2 times, most recently
from
6b5b7fb
to
13d6566
Compare
This is incomplete since, it's blocked by scalameta/scalameta#1212 (Add support to query type of a term) iset: immutable.Set[Int] cset: collecion.Set[Int] both have +/- implemented via SetLike given iset + 1 cset + 1 we know that + is from SetLike, but it's not possible to get the type of iset/cset Rewrite collection.Set.+ restrict type of lhs scalafix allow us to match on SetLike.+ but we cannot check the type of the expression on the lhs We can work arround this limitation if the lhs is a identifier (simple case). This allow us to document the expected type on the lhs and prepare the implementation once scalameta/scalameta#1212 is resolved
MasseGuillaume
force-pushed
the
c-map-set-plus
branch
from
13d6566
to
037561a
Compare
|
@julienrf ready for review |
julienrf
reviewed
Jun 26, 2018
| cset + 1 | ||
| cset - 2 | ||
| cmap + (2 -> 3) + ((4, 5)) |
There was a problem hiding this comment.
Can you also add the following test case?
- imap + (2 -> 3) + ((4, 5))
+ imap + (2 -> 3) + ((4, 5))
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is incomplete since, it's blocked by scalameta/scalameta#1212 (Add support to query type of a term)
iset: immutable.Set[Int]
cset: collecion.Set[Int]
both have +/- implemented via SetLike
given
iset + 1
cset + 1
we know that + is from SetLike, but it's not possible to get the type of iset/cset