Add ClassSignature.self (fix #1568) #1617
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
olafurpg
requested changes
Jun 21, 2018
| @@ -810,8 +810,7 @@ example.Example.main().(args) => param args: Array[String] | |||
| example.Example.x(). => val method x: ClassTag[Int] | |||
| ClassTag => scala.reflect.ClassTag# | |||
| Int => scala.Int# | |||
| local0 => selfparam self: Example | |||
| Example => example.Example. | |||
| local0 => selfparam self: <?> | |||
There was a problem hiding this comment.
Because previously we were saving synthetic self-type assigned to selfparams by scalac. In this PR, I found a way to separate the synthetic part from what's actually written in the source code. Now, selfparams without explicit type information have no signature.
| class C2 extends B { self: B => | ||
| } | ||
|
|
||
| class C3 extends B { self: B with Int => |
There was a problem hiding this comment.
Can we test that the name of the symbol is kept even when it's not self? For example, class A { hello => }?
There was a problem hiding this comment.
Done. The name is not kept in signatures though (because ScalaSignatures don't have the capacity to save it), only in occurrences.
For an explanation of the background, see scalameta#1618 (comment).
olafurpg
approved these changes
Jun 21, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on top of #1616 to separate large-scale and non-large-scale changes to SemanticDB. This PR was surprisingly easy to implement.