Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change metap macro synthetic printout to explain the expandee #1740

Merged
merged 1 commit into from
Aug 8, 2018

Conversation

maxov
Copy link
Member

@maxov maxov commented Aug 6, 2018

Continuing discussion from #1712, this changes the metap printout to be a backticked identifier. The goal is to have a printout that explains what is happening, is syntactically valid and can parse, but shouldn't compile.

Copy link
Member

@olafurpg olafurpg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 Thanks for following up on this @maxov I think this behavior is an improvement since it can potentially avoid unintended runtime errors.

@olafurpg olafurpg merged commit 20998a9 into scalameta:master Aug 8, 2018
@maxov maxov deleted the macro-expansion-tree-print branch August 8, 2018 17:23
@maxov
Copy link
Member Author

maxov commented Aug 8, 2018

Thanks for the merge! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants