Remove 70 publishable artifacts from the build. #1863
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Scalameta build currently contains a lot of micro-modules that have only a few source files. This commit merges these micro-modules into larger modules to reduce the complexity of the build and make releases easier. | Old (total cross-modules) | New | | ------------------------- | ---------------------- | | io (6) | trees | | inputs (6) | trees | | dialects (6) | trees | | tokens (6) | trees | | tokenizers (6) | trees | | transversers (6) | parsers | | quasiquotes (6) | parsers | | contrib (6) | scalameta | | metap (6) | scalameta | | metacp (2) | scalametaJVM | | symtab (2) | scalametaJVM | | cli (6) | scalameta | | semanticdb (6) | scalameta | | interactive (2) | semanticdb-scalac-core | | metai (2) | n/a | | semanticdb-javac (2) | n/a | The modules metai and semanticdb-javac were removed because they were not used by application that I'm aware of. People using those modules are invited to fork the source code and maintain the modules themselves. There are still 42 remaining publishable modules in the build: - common (6) - trees (6) - parsers (6) - scalameta (6) - semanticdb-scalac-core (9) - semanticdb-scalac (9) - testkit (2) - metac (2)
- remove javac compile options - disable mima for modules with no bincompat guarantee
olafurpg
pushed a commit
to olafurpg/scalameta
that referenced
this pull request
Nov 27, 2019
Previously, Scalameta kept a global cache for the tokens of all inputs. Now, the global cache has been replaced with a cache that's local to the input itself. The new solution was not possible before scalameta#1863 since the `Input` type was kept in a separate module from `Tokens`. Now the two types live in the same module so it's possible to make the token cache local to inputs. I verified that this change does not regress the performance of Scalafmt.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Scalameta build currently contains a lot of micro-modules that have only a
few source files. This commit merges these micro-modules into larger modules to
reduce the complexity of the build and make releases easier.
The modules metai and semanticdb-javac were removed because they were not used
by any application that I'm aware of. People using those modules are invited to fork
the source code and maintain the modules themselves.
There are still 42 remaining publishable modules in the build: