Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add as soft keword for pattern binding #2130

Merged
merged 1 commit into from Oct 6, 2020

Conversation

tgodzik
Copy link
Collaborator

@tgodzik tgodzik commented Oct 6, 2020

No description provided.

@tgodzik tgodzik force-pushed the add-as-pattern-binding branch 2 times, most recently from 335fb59 to c2ee768 Compare October 6, 2020 15:15
Copy link
Collaborator

@kpbochenek kpbochenek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@@ -105,7 +105,9 @@ final class Dialect private (
// Dotty allows by-name repeated parameters
val allowByNameRepeatedParameters: Boolean,
// Dotty allows lazy val abstract values
val allowLazyValAbstractValues: Boolean
val allowLazyValAbstractValues: Boolean,
// Dotty allows `at` instead of `@` for pattern bindings
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed!

@tgodzik tgodzik merged commit 5c4faa1 into scalameta:master Oct 6, 2020
@tgodzik tgodzik deleted the add-as-pattern-binding branch October 6, 2020 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants