Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding a Scala212Pre16 dialect #2758

Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -707,7 +707,9 @@ object Dialect extends InternalDialect {
Scala211,
Scala212,
Scala213,
Scala213Pre9,
Scala213Source3,
Scala212Pre16,
Scala212Source3,
Typelevel211,
Typelevel212
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -54,6 +54,12 @@ package object dialects {
.withAllowTryWithAnyExpr(true)
.withAllowQuestionMarkPlaceholder(true)

/**
* Dialect ending with Scala 2.13.9 for legacy F[_] syntax instead of F[?]
*/
implicit val Scala213Pre9 = Scala213
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why not Scala_2_13_8 instead?

.withAllowQuestionMarkPlaceholder(false)

/**
* Dialect starting with Scala 2.13.6 for `-Xsource:3` option
*/
Expand All @@ -79,6 +85,12 @@ package object dialects {
.withAllowPlusMinusUnderscoreAsIdent(true)
.withAllowGivenImports(true)

/**
* Dialect ending with Scala 2.12.15 for legacy F[_] syntax instead of F[?]
*/
implicit val Scala212Pre16 = Scala212
.withAllowQuestionMarkPlaceholder(false)

implicit val Scala = Scala213 // alias for latest Scala dialect.

implicit val Sbt0136 = Scala210
Expand Down