Adding a Scala212Pre16 dialect #2758
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kitbellew
requested changes
May 23, 2022
| /** | ||
| * Dialect ending with Scala 2.13.9 for legacy F[_] syntax instead of F[?] | ||
| */ | ||
| implicit val Scala213Pre9 = Scala213 |
There was a problem hiding this comment.
why not Scala_2_13_8 instead?
|
Thanks for the contribution! After thinking it over a bit, I think having a new dialect for older version would introduce too much work for the downstream projects such as yours. I went with an alternative approach in #2759 This should mean that no changes are needed for you downstream. |
|
Makes sense, thanks for your consideration here |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #2751
In preparation for #2757, to aide consumers who desire a seamless transition during the shakeout, introduce a new dialect that disallows the new
?placeholder syntax for both 2.12 and 2.13: