Only print ? for Scala 2 dialect if explicitly used
#2759
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced May 23, 2022
dos65
approved these changes
May 23, 2022
kitbellew
requested changes
May 23, 2022
scalameta/trees/shared/src/main/scala/scala/meta/internal/prettyprinters/TreeSyntax.scala
Outdated
Show resolved
Hide resolved
scalameta/trees/shared/src/main/scala/scala/meta/internal/prettyprinters/TreeSyntax.scala
Outdated
Show resolved
Hide resolved
scalameta/trees/shared/src/main/scala/scala/meta/internal/prettyprinters/TreeSyntax.scala
Outdated
Show resolved
Hide resolved
scalameta/trees/shared/src/main/scala/scala/meta/internal/prettyprinters/TreeSyntax.scala
Show resolved
Hide resolved
tests/jvm/src/test/scala/scala/meta/tests/prettyprinters/RegressionSyntaxSuite.scala
Show resolved
Hide resolved
tgodzik
force-pushed
the
fix-scala2-question
branch
from
1058513
to
37cadbc
Compare
kitbellew
approved these changes
May 23, 2022
scalameta/trees/shared/src/main/scala/scala/meta/internal/prettyprinters/TreeSyntax.scala
Show resolved
Hide resolved
tgodzik
force-pushed
the
fix-scala2-question
branch
from
37cadbc
to
b022d64
Compare
kitbellew
reviewed
May 23, 2022
tests/jvm/src/test/scala/scala/meta/tests/prettyprinters/RegressionSyntaxSuite.scala
Outdated
Show resolved
Hide resolved
tgodzik
force-pushed
the
fix-scala2-question
branch
2 times, most recently
from
cc41aa3
to
529281b
Compare
kitbellew
reviewed
May 23, 2022
| check("new-dialect-scala213", "type T = List[_]", "type T = List[_]", newDialect = Some(dialects.Scala213))( | ||
| dialects.Scala211 | ||
| ) | ||
| check("new-dialect-scala213-from-scala3", "type T = List[?]", "type T = List[?]", newDialect = Some(dialects.Scala213))( |
There was a problem hiding this comment.
i give up :) i am very bad at reviewing today. very sorry. please merge whenever you're ready.
i think i meant this test (original was underscore, not ?):
check("override-underscore-scala3-to-scala213", "type T = List[_]", "type T = List[?]")(dialects.Scala3)
it could also be
check("override-underscore-scala212-to-scala213", "type T = List[_]", "type T = List[?]")(dialects.Scala212)
There was a problem hiding this comment.
The two examples will not work since the original code has _, so when printing in 212 or 213 we will not introduce ?. I think it's a correct logic in this case.
There was a problem hiding this comment.
got it, thank you. approved earlier.
Previously, we would always print `?` for the placeholder even if the Scala version wouldn't allow it. Now, we only print `?` if it was explicitely used in the code. Fixes scalameta#2751 The other solution would be introducing another dialect, but that would require a lot of people having to also change that, so it would require a lot more effort in the long run.
tgodzik
force-pushed
the
fix-scala2-question
branch
from
529281b
to
8407933
Compare
kitbellew
approved these changes
May 23, 2022
|
Confirmed this fixed my problem! Awesome work, really appreciate it! |
Great to hear! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, we would always print
?for the placeholder even if the Scala version wouldn't allow it. Now, we only print?if it was explicitely used in the code.Fixes #2751
The other solution would be introducing another dialect, but that would require a lot of people having to also change that, so it would require a lot more effort in the long run.