Use StrongWolfeLineSearch implementation in LBFGS #59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dlwh
added a commit
that referenced
this pull request
Apr 24, 2013
Use StrongWolfeLineSearch implementation in LBFGS
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Credits to Aaron Defazio: https://gist.github.com/anonymous/5439754
What's still needed is good default values for maxZoomIter and maxLineSearchIter.
I could also try to refactor StrongWolfeLineSearch to implement ApproximateLineSearch.
I think the Bracket case class in CubicLineSearch should be equivalent to the State case class in ApproximateLineSearch.