New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revise configuration-related docs #1082
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks!
Change mentions of "transactions" (relating to Consensus Commit and gRPC) to "transaction managers".
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
[skip ci]
[skip ci]
[skip ci] Change `two-phase commit transactions` to `transactions with a two-phase commit interface` as noted in #934 (comment).
As discussed with @feeblefakie, I will be closing this PR and creating a new PR that includes the changes to these docs and targets branch I mistakenly used the docs from the |
The contents of this file matches the contents of the same file in a previous PR. Ref: #1082
[skip ci] The contents of this file matches the contents of the same file in a previous PR. Ref: #1082
Description
This PR revises configuration-related documents.
Related issues and/or PRs
N/A
Changes made
configurations.md
).configurations.md
).Branches this PR applies to
master
3.8
3.7
3.6
3.5
Testing done
I ran our docs site locally with these changes and confirmed that these revised docs, including content tabs, notice blocks, images, Mermaid diagrams, and formatting, appeared as expected. Attached are three screenshots for each doc in this PR.
The following screenshot shows configurations.md:
The following screenshot shows two-phase-commit-transactions.md:
The following screenshot shows multi-storage-transactions.md:
Checklist
Additional notes (optional)
Please see my comments in the revised files.