-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revise configuration-related docs (3.8) #1117
Conversation
Delete `configurations-for-consensus-commit.md` since its contents have been combined with `configurations.md`.
The contents of this file matches the contents of the same file in a previous PR. Ref: #1082
[skip ci] The contents of this file matches the contents of the same file in a previous PR. Ref: #1082
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for backporting the changes to these docs. It's pretty tricky to keep track of the feature getting deprecated or appearing.
[skip ci] This section only applies to version branch `4.0`. Co-authored-by: Vincent Guilpain <vincent.guilpain@scalar-labs.com>
[skip ci] This section only applies to version branch `4.0`. Co-authored-by: Vincent Guilpain <vincent.guilpain@scalar-labs.com>
[skip ci]
[skip ci] Co-authored-by: Vincent Guilpain <vincent.guilpain@scalar-labs.com>
[skip ci] Co-authored-by: Vincent Guilpain <vincent.guilpain@scalar-labs.com>
[skip ci] Co-authored-by: Vincent Guilpain <vincent.guilpain@scalar-labs.com>
[skip ci]
[skip ci] Remove notice about SQLite3 since it's not supported in 3.8 and earlier.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Torch3333 Thank you for your comments!🙏 I've incorporated many of your comments and will incorporate the rest when backporting PRs to earlier branches.
[skip ci] Change `transactionManager` to `manager` for 3.8 and earlier. `manager` was changed to `transactionManager` in 3.9.
[skip ci]
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thank you!
Update doc based on changes and comments in the following PR: #1117.
Update doc based on changes and comments in the following PR: #1117.
Update doc based on changes and comments in the following PR: #1117.
[skip ci] Update doc based on changes and comments in the following PR: #1117.
Update doc based on changes and comments in the following PR: #1117.
[skip ci] Update doc based on changes and comments in the following PR: #1117.
Update doc based on changes and comments in the following PR: #1117.
[skip ci] Update doc based on changes and comments in the following PR: #1117.
Description
This PR revises configuration-related documents.
Related issues and/or PRs
#1082
Changes made
This PR includes the same changes that were addressed in #1082:
configurations.md
).configurations.md
).configurations-for-consensus-commit.md
since its contents were previously combined withconfigurations.md
.Checklist
Additional notes (optional)
N/A
Release notes
N/A