feat: SQLite support via JDBC #762
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Dec 18, 2022
laysakura
force-pushed
the
feat/jdbc-sqlite
branch
from
40c46c3
to
3c27e60
Compare
laysakura
force-pushed
the
feat/jdbc-sqlite
branch
2 times, most recently
from
7db43c9
to
492769b
Compare
laysakura
force-pushed
the
feat/jdbc-sqlite
branch
from
db773cd
to
ba5ac05
Compare
laysakura
changed the title
|
The SQLite support finally got merge ready! |
brfrn169
reviewed
Apr 11, 2023
Comment on lines
24
to
25
| String jdbcUrl = System.getProperty(PROP_JDBC_URL, DEFAULT_JDBC_URL); | ||
| return jdbcUrl.startsWith("jdbc:sqlite:"); |
There was a problem hiding this comment.
Sorry, I missed this in the previous PR for some reason. Can you please add a method doing this in the JdbcEnv class, and call the new method here?
brfrn169
reviewed
Apr 13, 2023
Comment on lines
12
to
13
| private static final String PROP_JDBC_URL = "scalardb.jdbc.url"; | ||
| private static final String DEFAULT_JDBC_URL = "jdbc:mysql://localhost:3306/"; |
There was a problem hiding this comment.
Can you please also delete these?
There was a problem hiding this comment.
Sorry, I did it: d790e90
brfrn169
approved these changes
Apr 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a base (huge) pull request to fully support SQLite.
See separate pull requests for code review.