Upgrade to AutoPlugin #52
Conversation
This required updating all the scripted tests to use SBT version that supports autoplugins. The plugin, despite being named auto, will not load automatically now, to enable opt-in behavior for multi-project builds. This is a change from the previous version, where it was auto-loaded, hence another modification in scripted tests to enable the plugin.
|
Travis seems to have problems with OpenJDK. Looks similar to this problem: travis-ci/travis-ci#5227. All tests are green on OracleJDK, so, I guess, it shouldn't be blocker. |
Auto-load will enable more transparent migration for projects relying on old plugin behavior. Dropped SBT version in tests from 0.13.6 to 0.13.5, as the latter is when autoplugins were introduced.
|
I've added a workaround for Travis failures, and now the build is green. @matthewfarwell would you please consider merging and releasing this change? We rely on all of our SBT plugins to be AutoPlugins, and scalastyle-sbt is the last one without such feature. |
|
I will look at this over the next week. |
|
Thanks! |
|
Thanks @matthewfarwell for merging this. What about making an official release with this change (like 0.8.1 or even 0.9.0)? If anything else is needed to be completed before the release, I'd be happy to help. |
|
I will make a new release, but if you can tell me if it works for you - you should be able to try with the 0.9.0-SNAPSHOT release, that would be great as well. |
|
@matthewfarwell yes, I've checked the 0.9.0-SNAPSHOT, and it seems to work fine for me. In fact, I've been using locally built |
|
Cool. Thanks. |
|
@matthewfarwell can you publish this change externally please? |
This required updating all the scripted tests to use SBT version that
supports autoplugins.
The plugin, despite being named auto, will not load automatically now,
to enable opt-in behavior for multi-project builds. This is a change
from the previous version, where it was auto-loaded, hence another
modification in scripted tests to enable the plugin.
P.S. I'm not strongly advocating the opt-in behavior. For me it's most important that the plugin becomes an AutoPlugin. I'm ready to bargain on anything else to get this merged and released.